Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update required Scipy version #617

Merged
merged 8 commits into from
Jun 28, 2024
Merged

Update required Scipy version #617

merged 8 commits into from
Jun 28, 2024

Conversation

hsinfan1996
Copy link
Collaborator

@hsinfan1996 hsinfan1996 commented Feb 20, 2024 •
edited
Loading

#615 needs to be merged first in order not to make changes to the CI script.

@hsinfan1996 hsinfan1996 linked an issue Feb 20, 2024 that may be closed by this pull request
Update required Scipy version #616
Closed
@hsinfan1996 hsinfan1996 changed the title Rename simps Update required Scipy version Feb 20, 2024
@coveralls
Copy link

coveralls commented Feb 20, 2024 •
edited
Loading

Coverage Status

coverage: 100.0%. remained the same
when pulling 298614f on issue/616/scipy_simps_rename
into 714b92d on main.

@m-aguena
Copy link
Collaborator

@hsinfan1996 is ccl going to require this newer scipy version too?

@hsinfan1996
Copy link
Collaborator Author

hsinfan1996 commented Feb 21, 2024 •
edited
Loading

@hsinfan1996 is ccl going to require this newer scipy version too?

No, CCL does not depend on scipy. But ccl 3.0.1 is going to be released soon and the current mechanism for checking the version number will fail. I think it is quicker to fix it in this PR. I can do it in a separate PR if it is the proper way.
Moved to a new PR.

@hsinfan1996
Copy link
Collaborator Author

integrate.simps has been deprecated and will be removed in Scipy v1.14.

@hsinfan1996
Copy link
Collaborator Author

There is one more simps here, but I did not change it since it was commented out.

CLMM/clmm/utils/statistic.py

Line 213 in 714b92d

# cdf = np.array([simps(pdf_tab[:j], x_tab[:j]) for j in range(1, len(x_tab)+1)])

@m-aguena m-aguena merged commit d1bf0a1 into main Jun 28, 2024
2 checks passed
@m-aguena m-aguena deleted the issue/616/scipy_simps_rename branch June 28, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-aguena m-aguena m-aguena approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update required Scipy version
3 participants
@hsinfan1996 @coveralls @m-aguena